[101-103] New data and images #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willlarche
requested review from
mjohnsullivan,
filiph,
redbrogdon,
HansMuller and
maryx
|
That's a lot of images. It might be tidier to put the images in their own package. The Flutter Gallery example does this. |
|
Images moved to package. PTAL |
HansMuller
approved these changes
Apr 25, 2018
MDC-102/complete/lib/home.dart
Outdated
| @@ -29,7 +29,8 @@ class _HomePageState extends State<HomePage> { | |||
| new AspectRatio( | |||
| aspectRatio: 18 / 11, | |||
| child: new Image.asset( | |||
| 'assets/${product.id}-1.jpg', | |||
| '${product.id}-0.jpg', | |||
There was a problem hiding this comment.
Better encapsulation: product.assetName, product.assetPackage:
class Product {
String get assetName => '$id-0.jpg';
String get assetPackage => 'shrine_images';
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New images and data. Is there no easier way to have the images added to my project? It's a lot in my pubspec