This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Verify Production Types in Travis CI #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to catch error #857 we need to do a production type build for verification :-)
Codecov Report
@@ Coverage Diff @@
## rc0.14.0 #900 +/- ##
============================================
- Coverage 94.09% 94.08% -0.02%
============================================
Files 86 86
Lines 3644 3636 -8
Branches 574 573 -1
============================================
- Hits 3429 3421 -8
Misses 90 90
Partials 125 125
Continue to review full report at Codecov.
|
moog16
suggested changes
Jun 3, 2019
added 10 commits
June 3, 2019 12:48
|
My first idea (loading the .d.ts files to check for errors) doesn't seem to work. |
|
The tsconfig is required . . . |
|
That worked! Ready again @moog16 |
moog16
reviewed
Jun 11, 2019
added 2 commits
June 11, 2019 12:59
|
Test failures are from screenshots build and seem unrelated |
arichiv
commented
Jun 11, 2019
|
Can you updated with rc0.14.0. that will most likely fix your screenshot tests. |
added 2 commits
June 11, 2019 14:04
|
It's alive! |
moog16
suggested changes
Jun 11, 2019
|
I'm not sure what you mean @moog16. I have added no new errors. |
|
Yes, I understand index.ts is generated, however each error corresponds to somewhere in source. I was wondering if we could print where the actual error is coming from. |
|
@moog16 The comment above (as copied from Travis-CI) lists all found errors by source line in the imported type files. Is there something else you were looking for? The generated |
|
Are you asking for a trace to the source file (as opposed to compiled type file) @moog16? I'm not sure that makes sense (effort wise) as the issues we're concerned with are in the compiled types only (in some cases just because of the specific versions of external packages compiled against). If there's an easy way to trace the source of a line in a .d.ts file I'm not aware of I would be open to using it. Otherwise, I'll just be searching for the function names mentioned to track down errors. |
|
@arichiv - I've been thinking about what to do with your work. Here are my thoughts:
I think if you agree with all of these changes, I'm good on accepting them :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error #857 occurs in production builds against the generated type file.
In order to catch it a new Travis CI job was added which: