mwc-select #763
Merged
mwc-select #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
January 31, 2020 19:54
added 14 commits
January 31, 2020 19:55
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 1, 2020
- Implemented:
- `mwc-select`
- `mwc-menu`
- `mwc-menu-surface`
- `mwc-list`
- Implemented forked foundation
- `mwc-list-item`
- Base / utils.ts
- `isNodeElement` - performant node -> element checking
- `deepActiveElementPath` - finds the deepest `activeElement` node
- `doesElementContainFocus` - determines is ancestor of `activeElement`
- `mwc-radio.global` - groups radios across document rather than shadow root
- Style underline of filled textfield
- `--mdc-text-field-idle-line-color`
- `--mdc-text-field-hover-line-color`
Basic usage:
```html
<mwc-select outlined label="food">
<mwc-list-item selected value="" selected></mwc-list-item>
<mwc-list-item value="grains">
Bread, Cereal, Rice, and Pasta
</mwc-list-item>
<mwc-list-item value="vegetables">Vegetables</mwc-list-item>
<mwc-list-item value="fruit">Fruit</mwc-list-item>
</mwc-select>
```
Fixes #315
Fixes #212
FUTURE_COPYBARA_INTEGRATE_REVIEW=#763 from material-components:mwc-select 50636cb
PiperOrigin-RevId: 292662618
Merged
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 1, 2020
- Implemented:
- `mwc-select`
- `mwc-menu`
- `mwc-menu-surface`
- `mwc-list`
- Implemented forked foundation
- `mwc-list-item`
- Base / utils.ts
- `isNodeElement` - performant node -> element checking
- `deepActiveElementPath` - finds the deepest `activeElement` node
- `doesElementContainFocus` - determines is ancestor of `activeElement`
- `mwc-radio.global` - groups radios across document rather than shadow root
- Style underline of filled textfield
- `--mdc-text-field-idle-line-color`
- `--mdc-text-field-hover-line-color`
Basic usage:
```html
<mwc-select outlined label="food">
<mwc-list-item selected value="" selected></mwc-list-item>
<mwc-list-item value="grains">
Bread, Cereal, Rice, and Pasta
</mwc-list-item>
<mwc-list-item value="vegetables">Vegetables</mwc-list-item>
<mwc-list-item value="fruit">Fruit</mwc-list-item>
</mwc-select>
```
Fixes #315
Fixes #212
FUTURE_COPYBARA_INTEGRATE_REVIEW=#763 from material-components:mwc-select 50636cb
PiperOrigin-RevId: 292662618
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 3, 2020
PiperOrigin-RevId: 293012251
This was referenced Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mwc-selectmwc-menumwc-menu-surfacemwc-listmwc-list-itemisNodeElement- performant node -> element checkingdeepActiveElementPath- finds the deepestactiveElementnodedoesElementContainFocus- determines is ancestor ofactiveElementmwc-radio.global- groups radios across document rather than shadow root--mdc-text-field-idle-line-color--mdc-text-field-hover-line-colorBasic usage:
Fixes #315
Fixes #212