Skip to content

Bump pydata sphinx theme version #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Member

This bumps the pydata-sphinx-theme version to the same one currently being used on the Matplotlib docs (0.15.x).

@timhoffm
Copy link
Member

Why are we pinning to 0.15.x? Are there any known incompatibilities either 0.16.x?

Also, more generally, what is our update strategy? When do we plan to update and which checks should be performed?

@dstansby
Copy link
Member Author

My thinking was to be consistent with matplotlib/matplotlib, which is pinned to 0.15.x at the moment.

In terms of a update strategy, I think we should revive matplotlib/mpl-sphinx-theme#84 and put a pydata-sphinx-theme pin in the theme itself, which would avoid having to do this pinning across all the website repositories. Then we can set up dependabot in mpl-sphinx-theme to handle bumping the pydata version.

@dstansby
Copy link
Member Author

I've opened matplotlib/mpl-sphinx-theme#106 to move the pinning of pydata-sphinx-theme to mpl-sphinx-theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants