Add PatchWrappers for Annulus, Ellipse, Circle, Arc #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arc is still broken due to lack of setters in mpl proper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arc is still broken due to lack of setters in mpl proper
The simple patch example has been modified to use the new wrappers.
There is still a tension that I think needs to be addressed, particularly around initializing.
Shifting initialization to the subclasses may be necessary due to differences in the expected signatures/conditions (e.g. that width must be less than the semiminor axis for Annulus)
The
getattrwrapping makes this harder than I think it needs to be due to cases which hit infinite recursion...