EncryptionManager: un-deprecating EncryptionManager.getEncryptionKeys #4912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
commented
Jul 9, 2025
| @@ -114,6 +129,7 @@ export class RTCEncryptionManager implements IEncryptionManager { | |||
| public leave(): void { | |||
| this.transport.off(KeyTransportEvents.ReceivedKeys, this.onNewKeyReceived); | |||
| this.transport.stop(); | |||
| this.participantKeyRings.clear(); | |||
There was a problem hiding this comment.
The legacy encryption manager was only clearing its own key here, but I don't see why?
robintown
reviewed
Jul 11, 2025
BillCarsonFr
changed the title
robintown
approved these changes
Jul 11, 2025
toger5
approved these changes
Jul 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #4799
Fixes https://github.com/element-hq/voip-internal/issues/375
After discussions
IEncryptionManager#getEncryptionKeys()cannot be deprecated.There is a legit use case for the RTCSession beeing ready and running while the rtc app is not yet ready/started. That means that keys could be arriving already. Hence when the app is ready there should be a way to re-emit / access the keys.
Checklist
public/exportedsymbols have accurate TSDoc documentation.