Skip to content

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Jul 23, 2025

Follow-up to #5433.

This upgrade introduces support for room version 12. If clients want to test their support on servers that use the unstable org.matrix.hydra.11 version (like beta.matrix.org), the unstable-hydra feature of Ruma must be enabled.

Split into commits by theme for easier review, however they should be squashed together when merging.

@zecakeh zecakeh requested a review from a team as a code owner July 23, 2025 08:08
@zecakeh zecakeh requested review from andybalaam and removed request for a team July 23, 2025 08:08
@poljar poljar requested review from poljar and removed request for andybalaam July 23, 2025 08:18
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (6d562ef) to head (61c52f9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/room/members.rs 20.00% 8 Missing ⚠️
crates/matrix-sdk-base/src/room/create.rs 79.16% 5 Missing ⚠️
crates/matrix-sdk/src/room/member.rs 90.90% 3 Missing ⚠️
crates/matrix-sdk/src/room/mod.rs 77.77% 1 Missing and 1 partial ⚠️
...ates/matrix-sdk-base/src/deserialized_responses.rs 85.71% 1 Missing ⚠️
crates/matrix-sdk-base/src/room/mod.rs 91.66% 0 Missing and 1 partial ⚠️
crates/matrix-sdk-base/src/room/room_info.rs 85.71% 1 Missing ⚠️
crates/matrix-sdk-base/src/store/mod.rs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5436      +/-   ##
==========================================
- Coverage   88.86%   88.84%   -0.03%     
==========================================
  Files         333      333              
  Lines       91470    91547      +77     
  Branches    91470    91547      +77     
==========================================
+ Hits        81284    81332      +48     
- Misses       6362     6390      +28     
- Partials     3824     3825       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks very nice. Just a question about the unimplemented!() calls is left to discuss.

@jmartinesp
Copy link
Contributor

jmartinesp commented Jul 23, 2025

I'm still testing some of the changes, but so far these changes seem to work fine on Element X Android. Thanks!

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once we get rid of the merge conflicts we can get this in.

@poljar poljar enabled auto-merge (squash) July 23, 2025 14:31
@poljar poljar merged commit 0e622cc into matrix-org:main Jul 23, 2025
45 checks passed
@zecakeh zecakeh deleted the bump-ruma-hydra branch July 23, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants