-
Notifications
You must be signed in to change notification settings - Fork 331
Upgrade Ruma (phase 3) #5436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ruma (phase 3) #5436
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5436 +/- ##
==========================================
- Coverage 88.86% 88.84% -0.03%
==========================================
Files 333 333
Lines 91470 91547 +77
Branches 91470 91547 +77
==========================================
+ Hits 81284 81332 +48
- Misses 6362 6390 +28
- Partials 3824 3825 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks very nice. Just a question about the unimplemented!()
calls is left to discuss.
I'm still testing some of the changes, but so far these changes seem to work fine on Element X Android. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Once we get rid of the merge conflicts we can get this in.
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Follow-up to #5433.
This upgrade introduces support for room version 12. If clients want to test their support on servers that use the unstable
org.matrix.hydra.11
version (like beta.matrix.org), theunstable-hydra
feature of Ruma must be enabled.Split into commits by theme for easier review, however they should be squashed together when merging.