Fix rendering of m.receipt event in Client-Server API
#1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`type: enum` does not exist, as an enum can be of any type. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Removes duplicate definitions of PushRule and PushCondition Signed-off-by: Kévin Commaille <[email protected]>
Also resolve allOf of additionalProperties. Fixes names of objects refs and rendering of arrays Signed-off-by: Kévin Commaille <[email protected]>
Currently the pattern is ignored as there is always only one pattern in current definitions, and the pattern is clear with the descriptions. First step to render `m.receipt` event Signed-off-by: Kévin Commaille <[email protected]>
…object Fixes rendering of m.receipt and m.direct, and the body or response of a few endpoints Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
richvdh
requested changes
Sep 19, 2023
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
|
I addressed all the comments and improved further some descriptions. |
… rendered Signed-off-by: Kévin Commaille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes to make that happen also improved other parts of the spec:
m.receipt(current)m.direct(current)m.ignored_user_list(current)PushRuleandPushConditiondefinitions for them.push_rulesevent (current)POST /_matrix/client/v3/keys/signatures/upload(current)GET /_matrix/client/v3/thirdparty/protocols(current)additionalPropertiesin the CS and SS APIs, for example in the 200 response ofPOST /_matrix/client/v3/keys/query(current)Note that, for simplicity, the pattern of
patternPropertiesis ignored because usually the description is clear enough.Each commit can be reviewed separately.
Based on #1634 to avoid conflicts.
Closes #740.
Fixes part of #833.
Closes #1343.
Closes #1595.
Preview: https://pr1637--matrix-spec-previews.netlify.app