Skip to content

Consolidate Arel's definitions of impossibile and tautological conditions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewd
Copy link
Owner

Beyond reducing the number of instances of "1=0" strings, this incidentally fixes none.to_sql == where(id: []).to_sql (and by extension, the Relation#== equivalent), where they previously differed by unnecessary parens.

cc @codeminator

…ions

Beyond reducing the number of instances of "1=0" strings, this
incidentally fixes `none.to_sql == where(id: []).to_sql` (and by
extension, the Relation#== equivalent), where they previously differed
by unnecessary parens.

Co-authored-by: Ahmed Shahin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant