gh-96678: A few asserts to demonstrate undefined behaviour in 3.11 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
changed the title
matthiasgoergens
force-pushed
the
matthias/3.11-UB
branch
from
ad55f60 to
51ab076
Compare
matthiasgoergens
force-pushed
the
matthias/3.11-UB
branch
from
51ab076 to
f7bbda8
Compare
matthiasgoergens
changed the title
matthiasgoergens
commented
Sep 8, 2022
| @@ -812,11 +812,16 @@ bu_int(_structmodulestate *state, const char *p, const formatdef *f) | |||
| Py_ssize_t i = f->size; | |||
| const unsigned char *bytes = (const unsigned char *)p; | |||
| do { | |||
| assert(0 <= x); | |||
| assert(x <= (LLONG_MAX>>8)); | |||
There was a problem hiding this comment.
This one should be LONG_MAX.
| @@ -1558,6 +1564,7 @@ audioop_ulaw2lin_impl(PyObject *module, Py_buffer *fragment, int width) | |||
|
|
|||
| cp = fragment->buf; | |||
| for (i = 0; i < fragment->len*width; i += width) { | |||
| assert(0 <= st_ulaw2linear16(*cp)); | |||
There was a problem hiding this comment.
We'd also need to make sure that we don't left-shift the signed int too far.
Here and in the rest of this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from my asserts for
main.See python#96678