Skip to content

database/sql: feedback for non-DSN DB opener #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kardianos opened this issue Aug 15, 2017 · 3 comments
Closed

database/sql: feedback for non-DSN DB opener #450

kardianos opened this issue Aug 15, 2017 · 3 comments
Assignees
@mattn @gjrtimmer
Labels
enhancement help wanted
Milestone
2.0.0

Comments

@kardianos
Copy link

Related Issue: golang/go#20268
CL: https://go-review.googlesource.com/c/53430

There are two general ways we are considering supporting non-DSN opens.

The current CL has a Connector that is separate from the driver instance. I have a suspicion that it might be better to have the Connector be part of the Driver interface (see the CL comments).

Your feedback on this issue, CL, or the Go issue would be appreciated.
@gjrtimmer
Copy link
Collaborator

@mattn could you look into this ?

@kardianos
Copy link
Author

This is in go1.10. look up sql.OpenDB

@mattn mattn self-assigned this May 30, 2018
@gjrtimmer gjrtimmer self-assigned this Jun 12, 2018
@gjrtimmer gjrtimmer modified the milestones: 1.9.0, 2.0.0 Jun 12, 2018
@gjrtimmer
Copy link
Collaborator

This will be added with the v2.0.0 release

gjrtimmer added a commit to gjrtimmer/go-sqlite3 that referenced this issue Jul 23, 2018
@gjrtimmer
Close Issue on Merge
4049232 
Closes mattn#450

[skip ci]
@rittneje rittneje mentioned this issue Jan 16, 2022
Open
@rittneje rittneje closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattn mattn

@gjrtimmer gjrtimmer

Labels
enhancement help wanted
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@mattn @kardianos @gjrtimmer @rittneje