Add nil check in bind and a test #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
reviewed
May 31, 2018
| var nilSlice []byte | ||
| if _, err := db.Exec("insert into blob_not_null (b) values (?)", nilSlice); err == nil { | ||
| t.Fatal("didn't expect INSERT to 'not null' column with a nil []byte slice to work") | ||
| } |
There was a problem hiding this comment.
Could you please add test inserting 0 length slice too?
|
Thank you! |
|
@lucasmrod Thanks, great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #542.
There are extensive tests in the existing
TestNilAndEmptyBytes, but we cannot test the change in there because of howsqlite3_column_blob()works: "The return value from sqlite3_column_blob() for a zero-length BLOB is a NULL pointer." -> this means that bothNULLandzero-length blobmap to anilbyte slice. So... I ended up adding a separate testTestInsertNilByteSliceto check that storing a nil byte slice is now storing aNULL.