Use single-quotes around string literals #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
==========================================
- Coverage 46.80% 46.67% -0.14%
==========================================
Files 11 11
Lines 1457 1457
==========================================
- Hits 682 680 -2
- Misses 640 641 +1
- Partials 135 136 +1
Continue to review full report at Codecov.
|
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces double-quoted string literals with single-quoted ones in a few test cases. Double-quotes around string literals are invalid in standard-conforming SQL and accepting them by default is now considered a misfeature by the authors of SQLite. The test cases in question will also fail when SQLite is compiled with -DSQLITE_DQS=0.