Skip to content

Fix typos for serverVarialbeEnumIsValid and serverVarialbeDefaultExistsInEnum #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

PARAIPAN9
Copy link
Contributor

  • Fixes typos for serverVarialbeEnumIsValid and serverVarialbeDefaultExistsInEnum

@mattpolzin mattpolzin self-requested a review November 14, 2023 22:51
@mattpolzin mattpolzin changed the base branch from main to release/4_0 November 15, 2023 15:00
Copy link
Owner

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that spelling! I've switched the base branch to the next major version release because (although I am sure it is rare) it is possible that someone's code uses this validation by name currently and that would make renaming it a breaking change for that someone.

@PARAIPAN9
Copy link
Contributor Author

No problem, you're welcome! I actually found the spelling error while looking through the Swift-OpenAPI-Generator codebase.

@mattpolzin mattpolzin merged commit 3ea2bb4 into mattpolzin:release/4_0 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants