Skip to content

Changes following review #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from

Conversation

dcjarvis
Copy link

Changes based on @escopecz's review; removing references to authentication, making it clear where DDEV is used as an example and general tidy up

@escopecz
Copy link
Member

@dcjarvis it's common to push the changes to the same pull request (#241) than to create a new PR. Shall we close the older one?

@dcjarvis
Copy link
Author

@dcjarvis it's common to push the changes to the same pull request (#241) than to create a new PR. Shall we close the older one?

Oops yes I'll do that. Sorry, lack of experience and/or expertise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants