Skip to content

Fix missing embeds parameter #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: developer
Choose a base branch
from
Open

Fix missing embeds parameter #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions discord/interactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,7 @@ async def edit(
content=content,
flags=flags,
embed=embed,
embeds=embeds,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (edge_case_not_handled): Ensure handling of both embed and embeds parameters gracefully.

Given that both embed and embeds are now part of the parameters, it's important to ensure that the function can handle cases where both are provided, potentially merging them or prioritizing one over the other to avoid unexpected behavior.

attachments=attachments,
components=components,
allowed_mentions=allowed_mentions,
Expand Down