-
-
Notifications
You must be signed in to change notification settings - Fork 209
Add code to do color compositing on inpainting #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…discord.com/channels/1243166023859961988/1243185862234210389/1327390619068530729 into the Swarm UI, behind a ColorCorrectionBehavior flag that includes values "None" (the old behavior), "Uniform" (the fixed offset implemented in the file from discord), "Linear" (not implemented yet).
Also, add the diff to source instead of subtracting.
…e worse by correcting it.
…s funny artifacts.
The parameter should be... somewhere else. Honestly not sure where, maybe shoved under Advanced Sampling? Because it's needed for |
…ed sampling so it can be used for segment, per suggestions. (2) Switch toggleable to IgnoreIf: "None" per suggestions. (3) Remove output remainder and Hue adjustment from the Uniform sampler, to match Linear. I think these create more artifacts than they solve.
I can't think of a better spot for the parameter than Advanced Sampling; I put it under some VAE-related parameters. I tried doing some segment tests, the seam and the correction effect are pretty subtle. I'll add a couple to the bug thread. -- I ended up removing remainder() and also Hue from the 'Uniform' algorithm; there are some pretty clear examples from testing where those made things worse. |
This is intended as a fix for #597, which might take some further iteration.
Adds a UI parameter under 'Init Image' called 'Color Correction Behavior' with values 'None', 'Uniform', and 'Linear'.
You mentioned putting it behind a parameter; I assume you meant a UI parameter and not a server/user parameter that hides the UI parameter - I didn't see a lot of prior art for that but am open to fixing it.
I left the Uniform method as an option since I think the Linear option is not always better than it and people may want to experiment. I mostly left the code for Uniform as it was in the discord, but am open to: