Rework prepare_for_test #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
reviewed
Apr 25, 2025
Comment on lines
+226
to
+233
| if rtol is None: | ||
| if xp.isdtype(actual.dtype, ("real floating", "complex floating")): | ||
| # multiplier of 4 is used as for `np.float64` this puts the default `rtol` | ||
| # roughly half way between sqrt(eps) and the default for | ||
| # `numpy.testing.assert_allclose`, 1e-7 | ||
| rtol = xp.finfo(actual.dtype).eps ** 0.5 * 4 | ||
| else: | ||
| rtol = 1e-7 |
There was a problem hiding this comment.
No, it was an attempt to convince pyright. Regardless, I think it's slightly cleaner this way.
Comment on lines
+235
to
+236
| actual_np = as_numpy_array(actual, xp=xp) | ||
| desired_np = as_numpy_array(desired, xp=xp) |
There was a problem hiding this comment.
In data-apis#267 all testing becomes done exclusively by numpy.
So it makes sense to push the conversion into this function.
As a cascade effect, this makes type validation on behalf of pyright a lot easier.
mdhaber
approved these changes
Apr 25, 2025
|
Shoot, that was supposed to just confirm that the other 16 commits were just a merge. Can you resolve the merge conflicts? I think all you need to do is accept |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of review of data-apis#267
(change only in last commit; everything else is a merge from main)