This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Disabled request body parsing if the handler does nothing. #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…save memory and prevent crashes on large POST requests. Signed-off-by: Alexandr Zarubkin <[email protected]>
…ocess POST requests. Signed-off-by: Alexandr Zarubkin <[email protected]>
|
Hmm, I've noticed one drawback: if someone derives new subclasses of AsyncWebHandler which handle POST requests, he must not forget to redefine isRequestHandlerTrivial() function. Maybe this function should be marked as pure virtual to force being overridden in subclasses? |
|
Nice :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will save memory and prevent crashes on large POST requests.
Signed-off-by: Alexandr Zarubkin [email protected]