Add support for content type with charset #561
Conversation
Bmooij
force-pushed
the
feature/Support_Content-Type_with_charset
branch
from
8e7dab2 to
022328d
Compare
|
charset should be a separate variable :) it's not expected by the rest of the code to get such content type and some parsing may/will fail |
|
I walked into this problem when writing a flutter app. According to RFCs and it seems the "parameter" part of the Content-Type value is either mandatory or optional depending on the particular MIME type/subtype: |
| @@ -310,13 +310,11 @@ bool AsyncWebServerRequest::_parseReqHeader(){ | |||
| if(name.equalsIgnoreCase("Host")){ | |||
| _host = value; | |||
| } else if(name.equalsIgnoreCase("Content-Type")){ | |||
| _contentType = value.substring(0, value.indexOf(';')); | |||
There was a problem hiding this comment.
what happens if there is no ';' in the value? A check should likely be made to assign the substring only if there is a ';' mark otherwise use the value as-is.
There was a problem hiding this comment.
If value.indexOf returns -1 not found
value.substring returns the complete string
Bmooij
force-pushed
the
feature/Support_Content-Type_with_charset
branch
from
e41874b to
67640de
Compare
Add support for Content-Type with charset
Content-Type: text/html; charset=utf-8
It is ignoring the charset