Make Chunked Fill Array hold chunks #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the construction of regular chunks from the eachchunk call to the constructor of the Chunked FillArray. This enables to reuse the existing chunking pattern of actual data when constructing a ChunkedFillArray.
meggart
requested changes
Mar 21, 2025
src/DiskArrayTools.jl
Outdated
| chunksize::NTuple{N,Int} | ||
| value::T | ||
| arrsize::NTuple{N,Int} | ||
| chunks::GridChunks{N} |
There was a problem hiding this comment.
We are introducing type instability here, as GridChunks{N} is an abstract type
There was a problem hiding this comment.
Oh ok. Then I should make the chunks a parameter of ChunkedFillArray?
|
This would close #36 |
|
This should be replaced by RechunkedDiskArray(FillArray(val, size), chunks) as soon as RechunkedDiskArray is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the construction of regular chunks from the eachchunk call to the constructor of the Chunked FillArray. This enables to reuse the existing chunking pattern of actual data when constructing a ChunkedFillArray.
Currently
haschunks(::ChunkedFillArray)is false and I am wondering whether we should hard code this to true but I can't overview what this would entail.