Skip to content

Seek for stable #168

@PunitLodha

Description

@PunitLodha

Currently, on stable, seek doesn't work correctly
For seek implementation, https://github.com/meh/rust-ffmpeg/blob/master/src/format/io.rs#L93-L105, stream_len() is being used which is nightly only and 0 is returned in stable.
According to, rust-lang/rust#59359 and rust-lang/rust#58422, stream_len() is a convenience feature added for improved readability, which can be implemented manually by 3 seeks.

On stable, I think it would be better to manually implement using 3 seeks rather than, returning 0 which does not allow for a seek

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @PunitLodha

        Issue actions

          Seek for stable · Issue #168 · meh/rust-ffmpeg