added updateDocumentsCsv(string docs, string primaryKey) #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @sanders41 I have made all the changes according to your review. |
sanders41
requested changes
Jan 15, 2023
|
Hey, @sanders41 can you check it again? |
|
okay, Thank you. |
alallema
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Hi @sajdakabir,
Thanks for this PR and for contributing to Meilisearch ❤️
LGTM! 🎉
And sorry for the delay 😊
|
bors merge |
|
Build succeeded:
|
bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
678: Update version for the next release (v0.24.0) r=alallema a=alallema This version makes this package compatible with Meilisearch v1.0.0 🎉 Check out the changelog of [Meilisearch v1.0.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.0.0) for more information on the changes(#635). ##⚠️ Breaking changes * Make the usage of the module typing consistent (#625) `@pbrochar` * Put all dates to `datetime` type for consistency. Class impacted: `Task` and `TasInfo` (#661) `@Azanul` * Change `details` fields in `Task` class `Dict[str, Any]` -> `Union[Dict[str, Any], None]` (#664) `@Azanul` ## 🚀 Enhancements * Added `update_documents_csv(str_documents: str, primary_key: Optional[str] = None) -> TaskInfo` (#654) `@sajdakabir` ## 🐛 Bug Fixes * Include py.typed in package build (#637) `@sanders41` Thanks again to `@Azanul,` `@alallema,` `@pbrochar,` `@sajdakabir,` `@sanders41!` 🎉 Co-authored-by: alallema <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #347
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!