-
Notifications
You must be signed in to change notification settings - Fork 99
Add delete_documents_with method for Meilisearch v1.2 #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brunoocasali
merged 6 commits into
bump-meilisearch-v1.2.0
from
delete-documents-by-filter-ms-v1.2
May 31, 2023
Merged
Add delete_documents_with method for Meilisearch v1.2 #472
brunoocasali
merged 6 commits into
bump-meilisearch-v1.2.0
from
delete-documents-by-filter-ms-v1.2
May 31, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c5fa48
to
034ad31
Compare
irevoire
requested changes
May 23, 2023
af5f408
to
48eb944
Compare
48eb944
to
c5a843f
Compare
alallema
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
c5a843f
to
184d5cd
Compare
184d5cd
to
977e9da
Compare
irevoire
approved these changes
May 29, 2023
7b73ef0
to
0b5d7e9
Compare
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
May 31, 2023
472: Add delete_documents_with method for Meilisearch v1.2 r=bidoubiwa a=bidoubiwa following this spec: meilisearch/specifications#236 - Add a method `index.delete_documents_with` that lets you select a range of documents to delete based on the provided filters. Co-authored-by: meili-bot <[email protected]> Co-authored-by: Charlotte Vermandel <[email protected]> Co-authored-by: cvermand <[email protected]>
Timed out. |
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
May 31, 2023
472: Add delete_documents_with method for Meilisearch v1.2 r=bidoubiwa a=bidoubiwa following this spec: meilisearch/specifications#236 - Add a method `index.delete_documents_with` that lets you select a range of documents to delete based on the provided filters. Co-authored-by: meili-bot <[email protected]> Co-authored-by: Charlotte Vermandel <[email protected]> Co-authored-by: cvermand <[email protected]>
Build failed: |
meili-bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
476: Update version for the next release (v0.24.0) r=bidoubiwa a=meili-bot Release CHANGELOG: This version introduces features released on Meilisearch v1.2.0 🎉 Check out the changelog of [Meilisearch v1.2.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.2.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ### 🚀 Enhancements - Add a new `index.delete_documents_with(DocumentDeletionQuery)` method, which takes as a parameter a `DocumentDeletionQuery` struct. The struct has one builder method, `with_filter(filter: &str)`. The `filter` works precisely like the `filter` field used with the `search` method (see [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics)) and lets you determine which documents should be deleted. #472 `@bidoubiwa` - Add a new builder method `with_filter(filter: &str)` on `DocumentDeletionQuery` struct used by `index.get_documents_with`. The `filter` works precisely like the `filter` field used with the `search` method (see [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics)) and lets you determine which documents should be fetched. #473 `@bidoubiwa` These feature requires a Meilisearch server version greater than v1.2. Thanks again to `@bidoubiwa!` 🎉 477: Update code-samples for v1.2 r=bidoubiwa a=meili-bot _This PR is auto-generated._ Update the code-samples.meilisearch.yml according to the [integration-guides issue](meilisearch/integration-guides#270) for more information and the complete description about what should be done here check that issue. This is the [central issue](meilisearch/integration-guides#261) about the Meilisearch release v1.2 in the integrations. Co-authored-by: meili-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following this spec: meilisearch/specifications#236
index.delete_documents_with
that lets you select a range of documents to delete based on the provided filters.