Skip to content

add functions for csv documents #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2023
Merged

add functions for csv documents #508

merged 4 commits into from
Sep 12, 2023

Conversation

carlosb1
Copy link
Contributor

@carlosb1 carlosb1 commented Aug 23, 2023 •
edited by curquiza
Loading

Pull Request

Related issue

Fixes partially #191

What does this PR do?

Added the first two functions (with their tests) for issue #191. It includes two functions for sending csv payloads

  • add_documents_csv
  • update_documents_csv

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@carlosb1
Added csv operation
60b168e 
Signed-off-by: carlosb1 <[email protected]>
@carlosb1
Fixed tests
fe3cfe1 
Signed-off-by: carlosb1 <[email protected]>
@carlosb1 carlosb1 changed the title Feature/add csv operations WIP: add functions for csv documents Aug 23, 2023
@carlosb1 carlosb1 changed the title WIP: add functions for csv documents add functions for csv documents Aug 24, 2023
irevoire
irevoire approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks

@carlosb1
Copy link
Contributor Author

carlosb1 commented Sep 8, 2023

I think, the third PR that I have ready, it can be a problem... For send in batchs, it seems necessary the modification of the API or include some new function.

@curquiza
Copy link
Member

Hello @carlosb1

I'm not sure to understand your comment: do you think we should not merge your PR?

@carlosb1
Copy link
Contributor Author

no no... I am talking about the next ones.. I have another ready ... sorry, I should comment this in the next PR

curquiza
curquiza approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @carlosb1 for your PRs!

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 12, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 476ee7f into meilisearch:main Sep 12, 2023
@curquiza curquiza added the enhancement New feature or request label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

@curquiza curquiza curquiza approved these changes

@bidoubiwa bidoubiwa Awaiting requested review from bidoubiwa

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosb1 @curquiza @irevoire