Skip to content

Make the error type implement Send + Sync + 'static #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

Make the error type implement Send + Sync + 'static #571

merged 1 commit into from
Apr 16, 2024

Conversation

irevoire
Copy link
Member

Pull Request

Related issue

Fixes #570

What does this PR do?

  • Make the error type implement Send + Sync + 'static
  • Fix the awc example since their Error type doesn’t implement Send or Sync

@irevoire irevoire added the enhancement New feature or request label Apr 16, 2024
@irevoire irevoire requested a review from curquiza April 16, 2024 15:54
@irevoire irevoire mentioned this pull request Apr 16, 2024
Closed
curquiza
curquiza approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done tamo tamo

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Apr 16, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 85ceec4 into main Apr 16, 2024
@meili-bors meili-bors bot deleted the fix-other-error-type branch April 16, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updated meilisearch_sdk::errors::Error is no longer Send
2 participants
@irevoire @curquiza