Improve Docker configuration in the package #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
meili-bot/docker
branch
3 times, most recently
from
354b957 to
e566465
Compare
* Add FoundationNetworking imports for Linux support. * Remove autoreleasepool.
brunoocasali
force-pushed
the
meili-bot/docker
branch
from
e566465 to
4122cff
Compare
brunoocasali
reviewed
Aug 5, 2022
| client = try! MeiliSearch(host: "http://localhost:7700", apiKey: "masterKey", session: session) | ||
| client = try! MeiliSearch(host: currentHost(), apiKey: "masterKey", session: session) | ||
|
|
||
| let semaphore = XCTestExpectation(description: "Setup: delete all keys") |
There was a problem hiding this comment.
I thought XCTestExpectation should be used for expectations only inside of test cases, but it seems to be the recommended way from Apple to do async operations in the setup/teardown hooks.
The weirdest issue is related to the multi-env problem. When I ran that old configuration on Mac no issue at all. But when I ran locally on Docker, I got flaky tests! 😮💨
There was a problem hiding this comment.
There are still flacky tests in docker ?
brunoocasali
force-pushed
the
linux_support
branch
from
4122cff to
4b02ac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is auto-generated.
Add a basic Docker configuration based on this integration-guides issue.
ProcessInfo.processInfo.environment["MEILISEARCH_HOST"]