(Quick Wins) Fix Xcode 15, Reduce Search Requirements, Update README #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed regression with Xcode 15 upgrade, this change reverts back to original solution. We may wish to improve input validation in a future commit.
Previously we were requiring Codable (Decodable & Encodable) and Equatable protocol conformance on all documents returned by a search. For a simple read-only client this is unnecesary complexity. This is a simple non-breaking tweak to make it easier for clients.
This isn't as resilient as it was previously, but catches a very common use case. Docs updated.
1234 is not a valid URL and shouldn't have passed in the first place.
No functionality change other than using an approach which is compatible with more versions of Swift, addressing some issues caused by other PRs
curquiza
reviewed
Oct 5, 2023
curquiza
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #421
Fixes #420
Fixes #218
What does this PR do?
Nothing huge, new, or breaking. Just three real small issues on the project that this PR can quickly close down including a bug introduced in Xcode 15 - the test now passes locally but Xcode on GitHub defaults to Xcode 14.3 which doesn't have the issue.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!