[WC-2920]: Custom Chart config override #1553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
force-pushed
the
wc-2920_custom-chart-config-override
branch
from
8ec3476 to
ef43b4e
Compare
iobuhov
reviewed
Apr 30, 2025
packages/pluggableWidgets/custom-chart-web/src/controllers/ChartPropsController.ts
Outdated
Show resolved
Hide resolved
iobuhov
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
We have size configuration for some elements of the custom chart, this pr adds conditional logic for size handling given for the layout of the chart, therefore if user does apply configuration to those "size handled" properties, they will be able override and use their own values.