Bugfix and Improve the details in OLEDDisplayUiState during transition #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossan007
added a commit
to crossan007/Meshtastic-device
that referenced
this pull request
Feb 23, 2021
…sitions to/from plugin screens better It's still a bit janky, but should work meshtastic/esp8266-oled-ssd1306#2
|
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To any
drawFramefunctions consuming the OLEDDisplayUiState passed in the function parameters, we are adding two fieldstransitionFrameTargetis the id of the field being transitioned_intransitionFrameRelationshipdetermines whether the function being called is transitioning IN or OUTThe bug fix here seems to affect the spacing of the dots via
indicatorSpacingThe usage of these new fields may be observed in meshtastic-device Screen.cpp: https://github.com/meshtastic/Meshtastic-device/pull/705/files#diff-b96a4f56a51e883757b872d9680d6191810ababf13895af4ae816bcb783e4e54R159