Skip to content

raise SystemExit on build failure #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rgommers opened this issue Nov 23, 2022 · 0 comments · Fixed by #231
Closed

raise SystemExit on build failure #228

rgommers opened this issue Nov 23, 2022 · 0 comments · Fixed by #231
Labels
enhancement New feature or request

Comments

@rgommers
Copy link
Contributor

Good idea from @henryiii in #222 (comment): When Meson fails, we should raise SystemExit (like setuptools usually does), not throw an exception. Pip/build report a mess when there's an uncaught exception from the build hooks, while SystemExit is handled gracefully without nearly as many extra reports about missing build hooks and changed exceptions. The actual failure is printed by Meson.

@rgommers rgommers added the enhancement New feature or request label Nov 23, 2022
dnicolodi added a commit to dnicolodi/meson-python that referenced this issue Nov 24, 2022
dnicolodi added a commit to dnicolodi/meson-python that referenced this issue Nov 24, 2022
dnicolodi added a commit to dnicolodi/meson-python that referenced this issue Dec 21, 2022
FFY00 pushed a commit that referenced this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant