BUG: ignore macOS minor version #161
Conversation
Signed-off-by: Filipe Laíns <[email protected]>
There was a problem hiding this comment.
I now tested this on macOS arm64, and it works correctly there. However, the logic is wrong for macOS 10.x - there we do want to preserve the major version, it should result in (e.g.) 10_13 and not 10_0.
So it should be something like:
parts[1] = platform.mac_ver()[0]
if parts[1] > '11':
parts[1] = parts[1].split('.')[0]I can't test this, as I don't have a 10.x machine available. But from reading the code, this case isn't handled.
| @@ -51,7 +51,9 @@ | |||
| platform_ = sysconfig.get_platform() | |||
| if platform.system() == 'Darwin': | |||
| parts = platform_.split('-') | |||
| parts[1] = platform.mac_ver()[0] | |||
| parts[1] = platform.mac_ver()[0].split('.')[0] | |||
| if parts[1] in ('11', '12'): | |||
There was a problem hiding this comment.
Make it > '11', to avoid this breaking as soon as macOS 13 comes out?
There was a problem hiding this comment.
The idea is that packaging would have this fixed by then.
There was a problem hiding this comment.
Even with that fix, it still needs to be 13.0 for any 13.x OS version in the absence of MACOSX_DEPLOYMENT_PLATFORM. The packaging fix is only for when MACOSX_DEPLOYMENT_PLATFORM is explicitly set.
This is a follow-up to mesonbuildgh-161
This is a follow-up to mesonbuildgh-161 Signed-off-by: Filipe Laíns <[email protected]>
This is a follow-up to mesonbuildgh-161 Signed-off-by: Filipe Laíns <[email protected]>
This is a follow-up to gh-161 Signed-off-by: Filipe Laíns <[email protected]>
Fixes #160