TST: add test package depending on a cmake subproject #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
test-cmake-subproject
branch
from
a5d96df to
47de165
Compare
dnicolodi
force-pushed
the
test-cmake-subproject
branch
from
47de165 to
b1f6a08
Compare
This was referenced Mar 12, 2024
dnicolodi
added
the
dependency-bug
|
This is Draft until the upstream bugs are fixed, right? |
|
It depends on your definition of draft PR 🙂. The PR is complete, but there is a bug in Meson that makes merging it not productive. I keep this open just to remember ourselves of the bug: I don't know cmake at all and I don't have the spare cycles required to investigate this. |
|
👍🏼 In my book:
|
|
This was supposed to be non-draft and red, thus also not ready for review, probably. But it is so old that the test results have been flushed out. Setting it as draft now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.