Skip to content

V2 staging #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 77 commits into from
Sep 25, 2018
Merged

V2 staging #33

merged 77 commits into from
Sep 25, 2018

Conversation

epels
Copy link
Contributor

@epels epels commented Aug 3, 2018

The v2_staging branch combines all code for the bump to v2.

epels and others added 28 commits August 30, 2018 15:04
Remove premium SMS test. Premium is no longer supported.
Explicitly state we do not want to skip tests
Priorly, they connected to the actual API using a test key. This is not only slow, but also caused problems because group names must be unique for each user. It also put unnecessary load on the server.
Having them in the string is ok as it actually represents the object.
The Channel ID is a required param, so having a constructor without it is confusing.
Fixes the pipeline for add-conversations.
@epels epels merged commit 403ffd6 into master Sep 25, 2018
@epels epels deleted the v2_staging branch October 1, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants