-
Notifications
You must be signed in to change notification settings - Fork 81
V2 staging #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
V2 staging #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove premium SMS test. Premium is no longer supported.
Explicitly state we do not want to skip tests
Priorly, they connected to the actual API using a test key. This is not only slow, but also caused problems because group names must be unique for each user. It also put unnecessary load on the server.
Having them in the string is ok as it actually represents the object.
The Channel ID is a required param, so having a constructor without it is confusing.
Fixes the pipeline for add-conversations.
Mock transport
Add conversations
Add Java version to user agent
Bump version to 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
v2_staging
branch combines all code for the bump tov2
.