Skip to content

Please use semver and release 1.14.1 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
webmaster777 opened this issue Jun 5, 2019 · 3 comments
Closed

Please use semver and release 1.14.1 #94

webmaster777 opened this issue Jun 5, 2019 · 3 comments

Comments

@webmaster777
Copy link

Following semantic versioning (https://semver.org/), your "oops" version of 1.14.0.1 does not fit as proper release tag. You should issue a 1.14.1 patch release instead.

Also, if you want to use the version of your package inside your package, there are alternatives to using a hardcoded string

See:

Package managers could interpret 1.14.0.1 with the .1 suffix being a pre-release or build metadata info and not a real version.

@marcelcorso
Copy link
Contributor

hey @webmaster777. You are right we did something bad there. We'll release 1.14.1 very soon.

I also <3 the idea of not hardcoding the version inside the package. ocramius/package-versions looks like a good contender.
Could you do a PR for that? 🙏

@marcelcorso
Copy link
Contributor

@webmaster777
Copy link
Author

see #97. It has some implications so I hope you can clear up what you want as consequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants