Automatically insert version #97
Conversation
loadFromArray() is a public method, so the tests verify this behaviour.
PHP Notices were issued if the request doesn't contain the expected headers. Now, null values are passed to loadFromArray(), where the values will fail validation.
If expected values are missing or invalid when calling createFromGlobals() an exception is thrown. The example now demonstrates how an implementation can handle this and respond cleanly.
The value from $_SERVER is a numeric string, but an int is expected by the validation. Fixes messagebird#87
|
Nice, php < 7.1 also fails CI. I'd recommend dropping support for php < 7.1 |
see also #79 |
|
Thank you for the PR! Much fast! but... oh no. 7.1 is still supported https://www.php.net/supported-versions.php And yeah I agree with #79 . We'll have this conversation internally again. Thanks for the push. |
the php 7.1 CI doesn't fail. only <7.1 (so 7.0, 5.6 and below) |
Signedrequest notices
…-int SignedRequest request timestamp value must be an int
…-read-message Add read message method
…-example use correct method for conversations example
Add WhatsApp Sandbox support to Conversations API
Integrate the SDK with the partner account API to be able to CRUD sub accounts for the user which has the privilege to use the Partner Account feature. You can find the Partner Account documentation on the MessageBird website (https://developers.messagebird.com/)
Optimize or conditions.
…utes Add a .gitattribute file.
…ation Always use ::class notation.
…nder Change default sender in example code
…t-version-for-next-release bump-client-version
* implement automatic release notes generation * add release drafter config file * add release drafter config file * newline to fix template
The answer gives "items"
…st-api into feature-auto-version
|
@webmaster777 thank you for the PR. I did a small mistake and rebased your changes then "merged" with your remote branch so github actually let me to push (since --force isn't allowed) I will close this for now and consider using |
Using the
PackageVersions\Versionsclass requires composer and thus composer autoloading. This could be interpreted as BC break and thus require a v2.Alternatively you could consider not using composer autoloading plain idiocracy and pick this up in the next minor release, that would however technically be SemVer ;).
In both cases a change to
README.mdis advised.In aec85ca I've marked the constant as deprecated. Not sure If you'd consider the constant part of your public api, but it is publicly accessible. If not it should simply be removed without deprecation.