Disable SSL verification #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also solves issue #3 |
|
Could you provide me an example in which case this would be used? In case of a testing environment, I would argue that you would Mock the class to catch a request. Also, disabling the SSL verification would make it possible for a man-in-the-middle attack that could steal your used accesskey on your development environment. |
marcelcorso
pushed a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it possible to disable SSL verification. This should never be used in production environments but it makes developing a lot easier when no certificates are installed (e.g. a local installation).
I did not make the HTTP client publicly available with a getter since it's not available right now either. Instead I introduced two methods in the client which are directed to the HTTP client itself.
When the SSL verification flag is not set, PHP's default behavior is used.