-
Notifications
You must be signed in to change notification settings - Fork 94
Created Recipients object rather than it being a stdClass #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rfeiner can you have a look at this please? |
Thanks for your contribution, @JohnstonCode! And my apologies that it has not been picked up for so long. I personally think it would be super nice to add, however it is also a rather major change. Do you think we could maybe keep a way to preserve the old behaviour so that existing users can gradually migrate instead of having to do one "big bang" change? Maybe add a parameter to the getter, and by default keep the old behaviour in the first step, and then in a next version switch the default to the wdyt? |
Yeah that makes sense. I will update the PR later today. |
Looking back through the code i now remember why i did what i did. So the json_decode here turns |
Ah, you're right! That's on me for missing that, sorry. I will give this a spin later today and, if all goes well, merge it and release a new version. Thanks again for your contribution! |
No its my fault, I should have explained it better when i opened the PR. Brilliant, thank you. |
@modprobe did you manage to give it a try? |
@JohnstonCode Merged and released with v1.19.1! Thanks again! |
the recipients property in MessageBird\Objects\Message is currently just a stdClass. This PR creates a Recipients Object in its place to allow better autocomplete in IDEs