Signedrequest notices #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadFromArray() is a public method, so the tests verify this behaviour.
PHP Notices were issued if the request doesn't contain the expected headers. Now, null values are passed to loadFromArray(), where the values will fail validation.
If expected values are missing or invalid when calling createFromGlobals() an exception is thrown. The example now demonstrates how an implementation can handle this and respond cleanly.
|
thanks @chrisminett! I think you picked the right person to review this. If Alexs doesn't do it then maybe @rjelierse. |
modprobe
approved these changes
Jun 7, 2019
|
@modprobe are you able to merge if this is all good? Then I can open my other PR to fix the type issue on one of the same lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If expected header values are not set when using
SignedRequest::createFromGlobals(), PHP Notices are issued, which may get in the way of normal operation (eg. returning other headers).Update the method so that it checks for existence before access, and update the code example to show that
ValidationExceptions can be thrown if these values are missing.