Skip to content

SignedRequest request timestamp value must be an int #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2019
Merged

SignedRequest request timestamp value must be an int #99

merged 1 commit into from
Jun 11, 2019

Conversation

chrisminett
Copy link
Contributor

The value from $_SERVER['HTTP_MESSAGEBIRD_REQUEST_TIMESTAMP'] is a numeric string, but an int is expected by the validation in SignedRequest::loadFromArray()

Fixes #87

@chrisminett
SignedRequest request timestamp value must be an int
c34c82a 
The value from $_SERVER is a numeric string, but an int is expected by the validation.
Fixes messagebird#87
modprobe
modprobe approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@modprobe modprobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marcelcorso marcelcorso merged commit 30739d8 into messagebird:master Jun 11, 2019
@chrisminett chrisminett deleted the signedrequest-date-int branch June 11, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modprobe modprobe modprobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SignedRequest->createFromGlobals() does not set requestTimestamp to integer
3 participants
@chrisminett @modprobe @marcelcorso