Migrated OTP api to Verify api #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| # otp_verify requires a recipient, a token as required parameters, and other optional paramaters | ||
| client.otp_verify(31612345678, 123456, {:reference => "YourReference"}) | ||
| # verify_token requires the id of the verify request and a token as required parameters. | ||
| client.verify_token(31612345678, 123456) |
There was a problem hiding this comment.
First argument must be a verify id instead the phone number I guess
|
Hey 👋 thanks for working on this PR. Do you guys have any plan to have it merged soon? |
|
Hey, any update on this? We need the verify functionality. If there is anything missing, we are willing to help to get this merged |
|
thanks! can you also publish a new version (on github and rubygems) =) |
|
@p0wl 👍 |
|
is there a way to test the verify API with a |
|
@p0wl I don't think so but shoot an email to our friends at [email protected] and they can tell you for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samwierema breaking changes since the OTP Api doesn't exist anymore.