Windows Interface.index implementation
#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
changed the title
Interface.idx implementationInterface.index implementation
messense
force-pushed
the
windows-if-index
branch
from
d95fdb1 to
45e74a6
Compare
|
cc @shinypb |
shinypb
reviewed
Feb 28, 2023
| @@ -24,7 +24,7 @@ pub struct Interface { | |||
| /// The address details of the interface. | |||
| pub addr: IfAddr, | |||
| /// The index of the interface. | |||
| pub idx: Option<u32>, | |||
| pub index: Option<u32>, | |||
shinypb
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Awesome! Thanks for doing this.
I just glanced through https://learn.microsoft.com/en-us/windows/win32/api/iptypes/ns-iptypes-ip_adapter_addresses_lh and your Windows additions look totally reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.