Add initial OCR support in document_writer #134

yveszoundi · 2025-05-01T19:03:20Z

Initial OCR support in document_writer to create searchable PDF files with selectable text.

Add new method new_pdfocr_writer in document_writer.rs, as well as wrapper in wrapper.c for error handling (otherwise if OCR is disabled, applications will just crash silently).
Update build.rs for tesseract support, as it was not enabled by default
- Link against c++ standard libraries for tesseract, on non-Windows platforms
- Update GitHub Actions workflow for missing package dependencies

- Remove 'tesseract' from default features as it wasn't properly enabled - Update build.rs in 'mupdf-sys' to ensure that tesseract support is built properly - Introduce a new C wrapper method for error handling when the build has OCR disabled - A the method 'new_pdfocr_writer' to document_writer.rs Fix #128

yveszoundi · 2025-05-01T19:04:26Z

I don't have a solution yet for "arguments list too long" (Windows MSYS2 tests on GitHub Actions).

itsjunetime · 2025-05-01T22:24:08Z

For the "argument list too long" issue, this comment should help: #121 (comment)

Also you might want to rebase over main (or merge main into this branch) as it may (hopefully) help your CI issues.

yveszoundi · 2025-05-01T23:42:42Z

Thanks, this PR is based on latest main branch changes. I do have another repo forked from your previous 1.25 branch though.

It looks like USE_ARGUMENT_FILE was only added in MuPDF 1.26.0-rc1. I looked at the Makefile to double-check.

I'll check if I can pull that tag that into my branch.
There's also a pending pull request for updating mupdf to 1.26.0-rc1 it Update to [email protected] #129.

src/document_writer.rs

- Replace "&str" usages in document_writer with FilePath - Re-enable neon CPU flags in build.rs Fix #128

Fix #128

messense

Could you rebase onto main?

src/document_writer.rs

There's a hardcoded 60s timeout in cargo test infrastructure

messense · 2025-05-09T04:41:44Z

mupdf-sys/build.rs

+    let mut cpu_flags = DEFAULT_CPU_FLAGS.to_vec();
+    let target_arch = env::var("CARGO_CFG_TARGET_ARCH").unwrap_or_default();
+
+    if target_arch == "arm" {


Suggested change

if target_arch == "arm" {

if target_arch == "arm" || target_arch == "aarch64" {

also need to consider aarch64?

Previously, I only had aarch64 and the build was failing on GitHub Actions (OK locally on Mac OS x86_64).

I will give it a try though.

messense · 2025-05-09T04:43:22Z

mupdf-sys/build.rs

@@ -513,6 +528,20 @@ fn main() {
    println!("cargo:rerun-if-changed=wrapper.h");
    println!("cargo:rerun-if-changed=wrapper.c");

+    if let Ok(ref target_os) = env::var("CARGO_CFG_TARGET_OS") {
+        if target_os == "windows" {
+            #[cfg(target_env = "msvc")]


For cross compiling support, target_env should also be obtained from env vars.

Currently we also use cfg(target_env) in

mupdf-rs/mupdf-sys/build.rs

Line 245 in ed1d471

#[cfg(target_env = "msvc")]

and

mupdf-rs/mupdf-sys/build.rs

Line 54 in ed1d471

#[cfg(not(target_env = "msvc"))]

so we should prolly fix those parts sometime in the future as well.

I'll will make changes for other msvc references in build.rs as well.

yveszoundi · 2025-05-15T22:07:11Z

I'll see if I can submit a new pull request at some point. For now, I'll use my own fork.

It seems that the mupdf-sys build is under refactoring, so that would have likely put me in constant "rebase-mode" for a while.

ginnyTheCat · 2025-05-15T22:27:05Z

that would have likely put me in constant "rebase-mode" for a while

I'm sorry for changing so much. I will take care of the rebase so you can keep focusing on tesseract.

yveszoundi · 2025-05-15T22:39:18Z

It is not a problem at all and thank you. I appreciate your work.

yveszoundi added 17 commits April 28, 2025 11:11

Try enabling tesseract by default

1f9b2ce

Add flag for non windows target

3347da7

Add flag for non windows target

8e810f6

CI test fix

fb8a9ef

CI test fix

fc23493

CI test fix

dd81df4

CI test fix

25509bc

CI testing

c17336a

CI testing

c1944e2

CI testing

874df07

CI testing

2336e58

Fix typo

2f92b06

Use only neon instructions on arm64

867f633

Update package list for MSYS2 tests

5f1c89c

Disable neon CPU flags in build.rs

6451bec

CI disable some flags on windows

967e82e

CI issues on Windows

164f675

ginnyTheCat reviewed May 3, 2025

View reviewed changes

src/document_writer.rs Outdated Show resolved Hide resolved

yveszoundi added 8 commits May 3, 2025 10:31

Use FilePath type in document_writer

4f545bc

- Replace "&str" usages in document_writer with FilePath - Re-enable neon CPU flags in build.rs Fix #128

Fix formatting with rustfmt

6945e23

Fix #128

Conditionally enable neon flags for aarch64

52ab73b

Fix formatting with rustfmt

0a5c906

Fix #128

Different approach for neon flags on aarch64

7886ce5

Silence warnings in build.rs

2b5d5ac

Re-disable CPU neon flags

0db65ff

Try re-enabling neon CPU flags

d1d5e0d

yveszoundi added 3 commits May 3, 2025 22:16

Try re-enabling neon CPU flags

62420f8

Try re-enabling neon CPU flags

9f4e5d1

Retry approach for neon CPU flags

597f8f6

messense reviewed May 7, 2025

View reviewed changes

src/document_writer.rs Outdated Show resolved Hide resolved

yveszoundi added 12 commits May 7, 2025 12:18

Fix conflicts

d914601

Fix conflicts

497974a

Fix conflicts

24da27c

Fix conflicts

489239c

Fix conflicts

901d88b

Fix conflicts

34dbf61

Address conflicts

dd66e6c

Address conflicts

daf4457

Address conflicts

1124beb

Merge branch 'main' into yveszoundi/new_pdfocr_writer

dabacc2

Try fixing timeouts for windows-2019 tests

e6dbf1f

There's a hardcoded 60s timeout in cargo test infrastructure

Increase timeout for windows-2019 tests

0f8153e

messense reviewed May 9, 2025

View reviewed changes

yveszoundi closed this May 15, 2025

ginnyTheCat mentioned this pull request May 22, 2025

Add initial OCR support in document_writer #141

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add initial OCR support in document_writer #134

Add initial OCR support in document_writer #134

Uh oh!

yveszoundi commented May 1, 2025 •

edited

Loading

Uh oh!

yveszoundi commented May 1, 2025

Uh oh!

itsjunetime commented May 1, 2025

Uh oh!

yveszoundi commented May 1, 2025

Uh oh!

Uh oh!

messense left a comment

Uh oh!

Uh oh!

messense May 9, 2025

Uh oh!

yveszoundi May 9, 2025

Uh oh!

messense May 9, 2025

Uh oh!

ginnyTheCat May 9, 2025 •

edited

Loading

Uh oh!

yveszoundi May 9, 2025

Uh oh!

yveszoundi commented May 15, 2025

Uh oh!

ginnyTheCat commented May 15, 2025

Uh oh!

yveszoundi commented May 15, 2025

Uh oh!

Uh oh!

	if target_arch == "arm" {
	if target_arch == "arm" \|\| target_arch == "aarch64" {

Add initial OCR support in document_writer #134

Add initial OCR support in document_writer #134

Uh oh!

Conversation

yveszoundi commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yveszoundi commented May 1, 2025

Uh oh!

itsjunetime commented May 1, 2025

Uh oh!

yveszoundi commented May 1, 2025

Uh oh!

Uh oh!

messense left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

messense May 9, 2025

Choose a reason for hiding this comment

Uh oh!

yveszoundi May 9, 2025

Choose a reason for hiding this comment

Uh oh!

messense May 9, 2025

Choose a reason for hiding this comment

Uh oh!

ginnyTheCat May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yveszoundi May 9, 2025

Choose a reason for hiding this comment

Uh oh!

yveszoundi commented May 15, 2025

Uh oh!

ginnyTheCat commented May 15, 2025

Uh oh!

yveszoundi commented May 15, 2025

Uh oh!

Uh oh!

yveszoundi commented May 1, 2025 •

edited

Loading

ginnyTheCat May 9, 2025 •

edited

Loading