-
Notifications
You must be signed in to change notification settings - Fork 169
Adds TextStreamingDecoder
#1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1500
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 8832f44 with merge base 9295079 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
||
# We got a valid line, return it | ||
return line_data | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a shutdown method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, added in the new commit.
self.SOURCE_KEY: self.source.state_dict(), | ||
self.CURRENT_FILE_KEY: self._current_file, | ||
"current_line": self._current_line, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we also save METADATA_KEY?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i) like self.CURRENT_FILE_KEY
, i added self.CURRENT_LINE_KEY
.
ii) are you sure you meant saving METADATA_KEY
? DATA_KEY
and METADATA_KEY
play similar roles which i don't think needs to be saved.
thanks for the review. made some changes & pushed three commits. |
(note to myself)
|
This is a specialized file opener + decoder that