Skip to content

Conversation

a-kumar
Copy link

@a-kumar a-kumar commented Apr 12, 2018

@desandro @metafizzy. Please review and merge the code. Because this function removes code between script tags when loading next page.

Also If I commented code of this function script tag code are there but not working. So I have made my changes to work it.

Please let me know if you have any suggestions.

desandro added a commit that referenced this pull request Apr 13, 2018
@desandro
Copy link
Member

Hello! Thank you for this PR. I have opted to resolve this issue by copying the innerHTML, rather than calling eval. 🎉 v3.0.4 has been released with this fix added. Please update!

@a-kumar
Copy link
Author

a-kumar commented Apr 14, 2018

@desandro Thanks. I updated it and working fine for me. Will let you know if find anything else. Also there is one more issue I am getting in console log.

"TypeError: instance._init is not a function"

@desandro
Copy link
Member

Thanks for following up! See #768 for the _init issue.

@desandro desandro closed this Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants