feat(protractor): add e2e tests in CI #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shyam-Chen awesome! The build is passing now. Are we ready to merge? |
| @@ -28,7 +28,7 @@ | |||
| "serve.prod": "gulp serve.prod --color", | |||
| "start": "gulp serve.dev --color", | |||
| "tasks.list": "gulp --tasks-simple --color", | |||
| "test": "gulp test --color", | |||
| "test": "gulp test --color && gulp build.prod --color && gulp build.js.e2e --color && gulp e2e --color", | |||
There was a problem hiding this comment.
Lets move gulp e2e to a script called e2e and thus:
npm run e2eMost developers will expect to run only karma when run npm t.
There was a problem hiding this comment.
Also, we can have npm run tests.all which runs both npm test && npm run e2e. This command can be used in CI.
|
@Shyam-Chen really awesome job! Left some minor comments. |
|
OK |
|
LGMT! @Shyam-Chen ready for merge? |
|
merge |
This was referenced May 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #732