fix: Ensure all label pages are traversed and remove per_page from API and tests #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-------- cross-spawn <6.0.6 || >=7.0.0 <7.0.5 Severity: high Regular Expression Denial of Service (ReDoS) in cross-spawn - GHSA-3xgq-45jj-v275 Regular Expression Denial of Service (ReDoS) in cross-spawn - GHSA-3xgq-45jj-v275 --------
markscamilleri
commented
Jun 2, 2025
There was a problem hiding this comment.
npm warned me about a high vulnerability in cross-spawn (and 7 moderate) so I ran npm audit fix since a fix was available. Happy to revert if needed but I thought it's best to include this change here.
cross-spawn <6.0.6 || >=7.0.0 <7.0.5
Severity: high
Regular Expression Denial of Service (ReDoS) in cross-spawn - GHSA-3xgq-45jj-v275
Regular Expression Denial of Service (ReDoS) in cross-spawn - GHSA-3xgq-45jj-v275
That being said, this does not fix all the moderate ones as to do so requires updating a major version of @actions/github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that on PRs with lots of labels, this action can fail. After some investigation, I found out that the API is paginated (GitHub docs: List labels for an issue, Using pagination in the REST API), which means we need to wrap the call with
octokit.paginate()if we want to get all the labels.What changed
octokit.paginate()to fetch all labels for an issue, ensuring no labels are missed due to pagination.