Skip to content

feat: walking through dereferenced symlink directory #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

sephriot
Copy link
Contributor

@sephriot sephriot commented Jun 10, 2025

I've noticed that the content of a dereferenced directory symlink is not included in the archive, so I decided to fix it.

How it worked before:
If a symlink pointed to a directory that was not part of the files list, the directory was archived, but the content was not.

How it works now:
Both directory and its content are included in the archive.

Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

Thank you for this -- I haven't tested this myself (I'm not really a heavy symlink user) but let's go with this, and if people have issues with it would you be able to help maintain the patch?

@sephriot
Copy link
Contributor Author

@mholt sure, I'm up for a long term maintenance

@sephriot
Copy link
Contributor Author

@mholt If possible, could you please release a new version of the module once this PR is merged?

@sephriot
Copy link
Contributor Author

@mholt Please hit the merge button. I have no sufficient privileges to do so.

@mholt
Copy link
Owner

mholt commented Jun 26, 2025

Apologies, I was traveling and out of service for a few days. Thanks for your patience. I will try to tag a release soon!

@mholt mholt merged commit 8592d45 into mholt:main Jun 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants