-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add a selection of plugins to the core repo #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces new registry options for etcd and updates various components of the Consul and NATS brokers, cache, and encoding utilities while bumping dependency versions. Key changes include:
- Adding Auth and LogConfig options to the etcd registry.
- Enhancing the Consul registry watcher logic and tests.
- Updating broker implementations (NATS and HTTP) and adjusting the default broker configuration.
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
registry/etcd/options.go | Adds Auth and LogConfig functions for setting etcd registry options. |
registry/consul/watcher_test.go | Adds tests for healthy and unhealthy service handling in the Consul watcher. |
registry/consul/watcher.go | Updates service handling logic in the Consul watcher; includes colorful comments. |
registry/consul/registry_test.go | Adds tests for Consul service retrieval with varying health statuses. |
registry/consul/options.go | Adds functions for Consul-specific registry options. |
registry/consul/encoding(.go & _test.go) | Provides new encoding/decoding functions for endpoints, metadata, and versioning. |
go.mod | Updates dependency versions and adds new modules. |
cmd/cmd.go | Modifies default broker and registry mappings to incorporate new options. |
cache/rediscache/* | Includes new Redis cache implementation and related tests/options. |
broker/nats/* | Introduces NATS broker options, tests, and updates NATS broker implementation. |
broker/http/* | Updates HTTP broker implementation and tests to use revised broker interfaces. |
broker/broker.go | Changes DefaultBroker assignment to the memory broker. |
@asim this is ready to merge, more coming later |
add some plugins back to the repo