This repository was archived by the owner on Sep 6, 2023. It is now read-only.
esp32/ports/modnetwork.c: Implement network.WLAN.ifconfig('dhcp') #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should really be |
|
Yes, but that PR isn't merged yet.
…On Oct 30, 2017 22:44, "Nick Moore" ***@***.***> wrote:
Should really be (self->if_id == WIFI_IF_STA || self->if_id == ESP_IF_ETH)
since this function runs both!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYHCM0jZvoJ4wbdzJb3ro2EtFMho_vCks5sxrPBgaJpZM4QMMfy>
.
|
|
oooooooooooh *wait for it* ... yes it is :-) #187
|
|
Updated for wired LAN, squashed, pushed. |
|
Huh, looking at this, looks like I have a whole bunch of unrelated stuff in this commit. |
|
Sorry I missed this, it looks like it's still relevant (the |
|
Yes, yes I do, somewhere around here, a modified Waveshare LAN8720 board
wired to a DevKitC. If you want to update the branch to only have the bits you think it
should have, I can re-test.
Update: found it! It's even still plugged together, so just let me know when you're ready.
|
|
I'm going to be on holiday until the 25th, so probably after that. |
|
Working on this today. |
|
Closing -- will make new PR in main repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match other ports (CC3200)
Per discussion here: #187 (comment)